fixin’ pointers #2764
Open
fixin’ pointers #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointers in examples to either have hashes or be a file; also gave short explanation for private URI scheme in an xmp.
trishaoconnor
approved these changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
Thank you for your work on this @sydb, especially for catching those hashless pointers. I've tested these changes locally and it passes with no problem. I'm happy to approve these changes.
trishaoconnor
approved these changes
Sep 19, 2025
| <p>This example demonstrates the use of a <gi>ref</gi> element to provide more information about a person.</p> | ||
| <p>This example demonstrates the use of a <gi>ref</gi> element to provide more information about a person. | ||
| The private URI scheme <mentioned>lacy:</mentioned> is presumably | ||
| declared in the <gi>teiHeader</gi> with a <gi>prefixDef</gi>.</p> |
Contributor
There was a problem hiding this comment.
Thank you for this extra information and guidance on the lacy: prefix. This is a valuable addition.
torstenroeder
approved these changes
Sep 22, 2025
Contributor
torstenroeder
left a comment
There was a problem hiding this comment.
I had a close look on the changes and they look all very reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address #2763.
Updated a few hashless pointers in examples to either have hashes or to point to a local file.
Also gave short explanation for a private URI scheme in an example.