Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@trishaoconnor
Copy link
Contributor

@trishaoconnor trishaoconnor commented Jun 18, 2025

This PR addresses the missing <listRef>s highlighted in #2652. I have started work on this issue and added <listRef>s to the Spec pages of the following individual elements: <listRef>, <paramList>, and <outputRendition>. These were the most straightforward instances which clearly required a <listRef> and where there was a specific section in the Guidelines to which we could point.

I have not yet started to address the remaining specifications which also do not have a <listRef> (see table) as these other instances require further discussion at Council, but I hope that this PR could serve to store these future updates as well.

@ebeshero ebeshero added this to the Guidelines 4.10.0 milestone Jun 20, 2025
@ebeshero ebeshero self-requested a review June 23, 2025 03:37
Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trishaoconnor I reviewed this after writing an XQuery script to see if we can programmatically locate mentions of our specs that are missing <listRef>. Your PR helped me modify my code, so thank you for this work! :-) And I just request one small change to add one more <ptr> to the listRef spec.

</p>
</remarks>
<listRef>
<ptr target="#TDcrystalsCEdc"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To this I would also add:
<ptr target="#IM-unified"> because a significant mention of <listRef>appears there in context with how elements can be repeated without being grouped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added <ptr target="#IM-unified"> to <listRef> now. Thank you very much for finding this reference for me.

<ptr target="#WhereWeDiscussIt" type="div2"/>
<ptr target="#TDPMPM"/>
<ptr target="#TDPMOR"/>
<ptr target="#TDPMMC"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed <ptr target="#TDPMMC"/> as it only has an example in which <outputRendition> occurs but no actual discussion of the element that would be useful for a reader

Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after review and discussion in Stylesheets meeting today! Thanks @trishaoconnor !

@ebeshero ebeshero merged commit b158d75 into dev Jun 24, 2025
3 checks passed
@ebeshero ebeshero deleted the issue_2652 branch June 24, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants