-
Notifications
You must be signed in to change notification settings - Fork 96
Adding missing <listRef>s for #2652
#2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebeshero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trishaoconnor I reviewed this after writing an XQuery script to see if we can programmatically locate mentions of our specs that are missing <listRef>. Your PR helped me modify my code, so thank you for this work! :-) And I just request one small change to add one more <ptr> to the listRef spec.
| </p> | ||
| </remarks> | ||
| <listRef> | ||
| <ptr target="#TDcrystalsCEdc"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To this I would also add:
<ptr target="#IM-unified"> because a significant mention of <listRef>appears there in context with how elements can be repeated without being grouped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added <ptr target="#IM-unified"> to <listRef> now. Thank you very much for finding this reference for me.
P5/Source/Specs/outputRendition.xml
Outdated
| <ptr target="#WhereWeDiscussIt" type="div2"/> | ||
| <ptr target="#TDPMPM"/> | ||
| <ptr target="#TDPMOR"/> | ||
| <ptr target="#TDPMMC"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed <ptr target="#TDPMMC"/> as it only has an example in which <outputRendition> occurs but no actual discussion of the element that would be useful for a reader
ebeshero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after review and discussion in Stylesheets meeting today! Thanks @trishaoconnor !
This PR addresses the missing
<listRef>s highlighted in #2652. I have started work on this issue and added<listRef>s to the Spec pages of the following individual elements:<listRef>,<paramList>, and<outputRendition>. These were the most straightforward instances which clearly required a<listRef>and where there was a specific section in the Guidelines to which we could point.I have not yet started to address the remaining specifications which also do not have a
<listRef>(see table) as these other instances require further discussion at Council, but I hope that this PR could serve to store these future updates as well.