Refactorisation des votes pour permettre de voter pendant l'ajout de chansons #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdbm
reviewed
Sep 7, 2022
Merged
3 tasks
Merged
Ithyx
added a commit
that referenced
this pull request
Sep 23, 2022
* Migration vers Fly.io (#38) * Added memory usage estimation to dashboard * First dockerfile * Added dockerfile and fly.io config * Added deploy workflow and removed heroku procfile * Added env file generation for workflow * Finished CI for Fly.io deploy * Refactorisation des votes pour permettre de voter pendant l'ajout de chansons (#40) * TS maintenant target es6 * Refactor des votes et suppression des votes lorsqu'on supprime une chanson * Suppression des favoris lors de la suppression d'une chanson * Refactoring des favoris pour les hierarchiser sous le module des chansons * Removed leftover log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cette PR refactor les favoris et les votes pour les mettres au même niveau. Ceci permet de supprimer toutes les ressources nécessaires lorsqu'un utilisateur décide de supprimer une chanson.
🎉 Quality of life
La période des vote et la période d'ajout de chansons ont maintenant été fusionnées.
🐛 Bugfix
🛠️ Refactoring
Checklist