Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

xotea
Copy link
Contributor

@xotea xotea commented Oct 22, 2025

Fixes: #1703

🎯 Changes

This PR fixes an issue that the previous generic had for interfaces in TypeScript similarly to #1601.

The purpose and the implementation is exactly the same, but now for withFieldGroup instead of withForm.

βœ… Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

πŸš€ Release Impact

  • This change affects published code, and I have generated a changeset.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

πŸ¦‹ Changeset detected

Latest commit: b6830e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/react-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

@nx-cloud
Copy link

nx-cloud bot commented Oct 23, 2025

View your CI Pipeline Execution β†— for commit b6830e5

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... βœ… Succeeded 58s View β†—
nx run-many --target=build --exclude=examples/** βœ… Succeeded 6s View β†—

☁️ Nx Cloud last updated this comment at 2025-10-23 08:31:10 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1816

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1816

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1816

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1816

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1816

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1816

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1816

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1816

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1816

commit: b6830e5

@LeCarbonator LeCarbonator merged commit ca31ede into TanStack:main Oct 23, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 51.91%. Comparing base (6892ed0) to head (b6830e5).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1816       +/-   ##
===========================================
- Coverage   90.35%   51.91%   -38.45%     
===========================================
  Files          38       14       -24     
  Lines        1752      183     -1569     
  Branches      444       29      -415     
===========================================
- Hits         1583       95     -1488     
+ Misses        149       77       -72     
+ Partials       20       11        -9     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withFieldGroup#props does not support interfaces

2 participants