-
-
Notifications
You must be signed in to change notification settings - Fork 534
fix(react-form): allow interfaces to be assigned to withFieldGroup
's props
#1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-form): allow interfaces to be assigned to withFieldGroup
's props
#1816
Conversation
π¦ Changeset detectedLatest commit: b6830e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick fix!
View your CI Pipeline Execution β for commit b6830e5
βοΈ Nx Cloud last updated this comment at |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
===========================================
- Coverage 90.35% 51.91% -38.45%
===========================================
Files 38 14 -24
Lines 1752 183 -1569
Branches 444 29 -415
===========================================
- Hits 1583 95 -1488
+ Misses 149 77 -72
+ Partials 20 11 -9 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Fixes: #1703
π― Changes
This PR fixes an issue that the previous generic had for interfaces in TypeScript similarly to #1601.
The purpose and the implementation is exactly the same, but now for
withFieldGroup
instead ofwithForm
.β Checklist
pnpm test:pr
.π Release Impact