Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[NPE] Add GCP Pubsub Support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Sep 22, 2025
Merged

[NPE] Add GCP Pubsub Support #72

merged 27 commits into from
Sep 22, 2025

Conversation

@ojameso
Copy link
Contributor

@ojameso ojameso commented Jul 15, 2025 •
edited
Loading

This adds GCP PubSub support.

Adds both Chore::Queues::PubSub::Consumer and Chore::Queues::PubSub::Producer. this can be configured numerous ways. Interesting notes regarding configuration have been added to the README.

Breaking change

  1. Moves AWS-SQS to dev-dependency and not runtime since we can now use either AWS or GCP.
  2. Drops support for Ruby 2.7

Nonbreaking change

  1. Add PubSub support
  2. Queue creation tasks now separate into create_sqs/create_pubsub tasks.

Testing

  • TIAB - Was able to create a test job in tapjoyserver to read/write form the Queue.

@ojameso ojameso self-assigned this Jul 15, 2025
@ojameso ojameso force-pushed the npe/add_pubsub branch 2 times, most recently from 3077b4c to a783675 Compare August 14, 2025 21:34
@ojameso ojameso marked this pull request as ready for review August 14, 2025 22:45
@ojameso ojameso requested a review from a team as a code owner August 14, 2025 22:45
@ojameso ojameso requested review from a team and captainkevron and removed request for a team August 14, 2025 22:45
@ojameso ojameso force-pushed the npe/add_pubsub branch 5 times, most recently from e6f898e to 4e165ea Compare August 15, 2025 22:05
captainkevron
captainkevron reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@captainkevron captainkevron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions. I am not very familiar with the Chore architecture, so I mostly used the SQS implementation as a reference to compare against. Nice work on the README.md updates.

@ojameso ojameso requested a review from obrie August 19, 2025 21:34
obrie
obrie requested changes Aug 20, 2025
View reviewed changes
@ojameso ojameso requested a review from obrie September 4, 2025 16:53
obrie
obrie reviewed Sep 5, 2025
View reviewed changes
obrie
obrie reviewed Sep 5, 2025
View reviewed changes
obrie
obrie approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@obrie obrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments are nice-to-have cleanup. Functionally everything looks good here. Going to approve as-is and leave it up to you how much cleanup you want to do.

adnissen
adnissen reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@adnissen adnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ojameso ojameso merged commit 4fc9a89 into master Sep 22, 2025
9 checks passed
@ojameso ojameso deleted the npe/add_pubsub branch September 22, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainkevron captainkevron captainkevron left review comments

@obrie obrie obrie approved these changes

+1 more reviewer

@adnissen adnissen adnissen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ojameso ojameso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ojameso @obrie @adnissen @captainkevron