Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix crash on unknown variable #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TarCV merged 1 commit into from
Apr 17, 2020
Merged

Fix crash on unknown variable #8

TarCV merged 1 commit into from
Apr 17, 2020

Conversation

@TarCV
Copy link
Owner

@TarCV TarCV commented Apr 16, 2020

Fix #2

@TarCV TarCV mentioned this pull request Apr 16, 2020
Closed
@ghost
Copy link

ghost commented Apr 16, 2020

Using https://github.com/TarCV/debotc/blob/master/debotc_defs.bts as botc_defs.bts and mentioning an undeclared $global6 variable anywhere in the source:

Parsing script...
Declared global variable #0 $global0
Declared global variable #1 $global2
Declared global variable #2 $global3
Declared global variable #3 $global4
Declared global variable #4 $global5
Declared global variable #5 $globalArray1
error: crashbot.botc:14:11: unknown variable $global6

It works as intended.

@TarCV TarCV merged commit 0b4cf97 into tarcv-master Apr 17, 2020
@TarCV TarCV deleted the fix-var-crash branch April 17, 2020 02:15
@TarCV
Copy link
Owner Author

TarCV commented Apr 17, 2020 •
edited
Loading

Thank you. Merged.

Does botc_defs from this repository work for you? The one from debotc repo is good for debugging as it allows compiling sources produced by debotc, but it might lack some fixes or updates.

@ghost
Copy link

ghost commented Apr 17, 2020

It doesn't work when compiling the decompiled crashbot source, that is why I used the debotc one.

@ghost
Copy link

ghost commented Apr 17, 2020 

Parsing script...
Declared global variable #0 $global0
Declared global variable #1 $global2
Declared global variable #2 $global3
Declared global variable #3 $global4
Declared global variable #4 $global5
Declared global variable #5 $globalArray1
error: crashbot.botc:27:20: IsSpectating returns an incompatible data type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Silent crash on encountering undefined variable

2 participants

@TarCV