Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@outloudvi
Copy link
Contributor

@outloudvi outloudvi commented Jun 24, 2025

I see #694 adds both Policy.OpenGraph and Options.OpenGraph. While the configuration is populated in Policy.OpenGraph, it's still Options.OpenGraph that is read, which is unfortunately not populated.

Note:

  • Maintainers may need to decide whether to use Policy.OpenGraph or Options.OpenGraph, but I received a report saying my anubis-fronted site lost OpenGraph passthrough, so here is a quick fix for whoever is concerned.
  • For the reason state above, I do not expect this PR to be merged as I guess maintainers want to gradually switch to Policy.OpenGraph?
  • BTW I reverted to anubis v1.18.0 on my website, which does not have this regression.

Checklist:

  • Added a description of the changes to the [Unreleased] section of docs/docs/CHANGELOG.md
  • Added test cases to the relevant parts of the codebase
  • Ran integration tests npm run test:integration (unsupported on Windows, please use WSL)

@outloudvi outloudvi marked this pull request as ready for review June 24, 2025 15:07
@Xe Xe enabled auto-merge (squash) June 24, 2025 15:08
@outloudvi outloudvi changed the title Populate OpenGraph configurations to Opens.OpenGraph Populate OpenGraph configurations to Options.OpenGraph Jun 24, 2025
@Xe Xe merged commit 15bd9b6 into TecharoHQ:main Jun 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants