Fix and clean CI after Nim 2.2.0 update #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
approved these changes
Oct 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify template's return type for correct variable declaration
I specified the return type of a template in strings/check_anagram.nim
There was an error about non-discarded char elements, as somehow these values were not considered part of the declaration.
I am not super fan of this fix, as one branch of the case switch just errors out and do not return a value. I am all ears for a better fix.
[modular_inverse] Reduce the number of tests to make CI readable again
The CI was not very readable due to a too great number of tests in the maths/modular_inverse.nim file. I reduced the number of tests from 1000 to 10.