Expose pub(crate) fn new constructors for value types
#457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDan64
approved these changes
Jan 10, 2024
Owner
|
@corbanvilla The newly pub fns need doc comments. Also, |
Contributor
Author
|
@TheDan64 apologies for the delay, just added doc comments! |
Owner
|
@corbanvilla there appear to be some merge conflicts that need to be resolved |
Contributor
Author
|
@TheDan64 Could you clarify where you're referring to.... it looks up to date under the files changed tab. |
Owner
|
For some reason I see |
Owner
|
ah okay it looks like I can do a regular merge instead of a rebase... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposing these constructors is helpful when working with LLVM code which isn't yet part of the C-API.
Related Issue
InstructionValue::newispub(crate)instead ofpub#424Checklist