Remove support for LLVM4-7 #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes support for LLVM versions 4–7, updating conditional compilation attributes and feature flags throughout the codebase to only support LLVM 8 and later.
- Removed deprecated conditional blocks for LLVM4-7 in tests and source files
- Updated attributes and feature flags to reflect LLVM8+ only support
- Revised Cargo.toml and README documentation to align with the new supported LLVM versions
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/all/test_module.rs | Removed unnecessary conditional blocks for source file name |
| tests/all/test_debug_info.rs | Updated cfg attributes for basic type creation |
| tests/all/test_builder.rs | Removed old LLVM4-7 feature flags from builder tests |
| src/values/mod.rs, metadata_value.rs, etc. | Updated #[llvm_versions(7..)] to #[llvm_versions(8..)] across modules |
| src/module.rs, src/execution_engine.rs | Refactored inline assembly and function pointer handling |
| Cargo.toml, README.md | Removed references to LLVM4-7 and updated version features |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed support for LLVM4-7 per removal policy in #529
Related Issue
Closes #576
How This Has Been Tested
cargo t --features llvm18-0Option<Breaking Changes>
Removed support for LLVM4-7
Checklist