Removes uneccesary less-than 64-bit check on 32-bit value. #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm also working on some changes that will allow you to set the alignment during operations where the alignment could be specified. So for example, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The is_alignment_ok function in builder.rs uses log2 to determine the number of bits that are number needs. It compares the result with
64. This is unnecessary as thealignparameter is only 32-bits, so this comparison will always returntrue.If
alignwere 64-bit, the check would still be unnecessary because you can't have 2^64 as a 64-bit value. Ifalignwere 128-bit, then you could perform this check usingalign.trailing_zeros(), which is faster than converting to f64 and using log2, which would be inaccurate for an 128-bit integer anyway.How This Has Been Tested
No tests needed. It's logically sound.
Checklist