Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removes Either dependency. #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Removes Either dependency. #610

wants to merge 8 commits into from

Conversation

@ErisianArchitect
Copy link
Contributor

Description

Either tends to make code a little harder to read, and a little harder to write, so I decided it would be a good idea to remove the dependency entirely and instead rely on tailored enums to do the job.

Related Issue

#609

How This Has Been Tested

All tests passed for all supported versions of LLVM on Windows.

Option<Breaking Changes>

Breaking changes for readability.

Checklist

(I ran cargo clippy this time, hopefully github actions doesn't complain anyway)

@ErisianArchitect
Copy link
Contributor Author

Oh, shoot, I just realized that I forgot to write documentation for the new enums. Let me do that real quick before merge.

@ErisianArchitect
Copy link
Contributor Author

Oh, and CallableValue had Either inside it, so I figured it would be a good idea to replace the Either with an enum rather than replacing CallableValue with an enum. If you think it would be better to replace CallableValue itself with an enum, let me know. I figured there was a reason that it hid away the Either before.

@TheDan64 TheDan64 self-requested a review October 21, 2025 06:22
@ErisianArchitect
Copy link
Contributor Author

I should probably mention: This PR conflicts with #607. I didn't realize that until after I made the PR. For some reason I thought that it had already been merged, so I didn't think there would be a conflict.

@ErisianArchitect
Copy link
Contributor Author

Any update on this? I'd like to start work on the next PR.

@TheDan64
Copy link
Owner

I won't be able to look at this until the end of the week

@ErisianArchitect
Copy link
Contributor Author

Alright, I've got a side project I'm working on anyway, so no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheDan64 TheDan64 Awaiting requested review from TheDan64

At least 1 approving review is required to merge this pull request.

Assignees

@ErisianArchitect ErisianArchitect

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ErisianArchitect @TheDan64