Add llvm21-1 tests #631
Merged
Add llvm21-1 tests #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TheDan64 is it possible to release a new version of the inkwell that includes that fix ? |
Owner
|
We'll likely do a release after the holidays. Trying to see if we can get some of the active PRs merged first. |
Contributor
@TheDan64 are there any PRs now that a blocking release of inkwell ? |
Owner
|
You can follow the remaining issues for the release here: https://github.com/TheDan64/inkwell/milestone/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for llvm21-1 and adapts one failing test to reflect LLVM api changes.
The
test_get_next_usetest can't be tested with constant data in llvm21-1 and over. According to the release notes: It is no longer permitted to inspect the uses of ConstantData. Use count APIs will behave as if they have no uses (i.e. use_empty() is always true). (Link). To adapt the test, I switched to using analloca + store + load, but only conditionally for feature llvm21-1.Related Issue
#630
How This Has Been Tested
Ran tests for all llvm versions as well as linting test on my fork.
Option<Breaking Changes>
None
Checklist