Add Helm chart validation workflows #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical template issues and adds comprehensive CI/CD validation to prevent similar issues in the future.
Problem
GitHub issue #61 identified a critical bug where malformed YAML in Helm templates caused deployment failures when Redis was disabled (the default configuration). The workflow also lacked automated validation to catch such issues before merge.
✨ New Features
3. Helm Lint Workflow (
.github/workflows/helm-lint.yml)Triggers:
mainorgh-pages(auto-run on chart changes)helm-lintlabel is added to PRValidation Steps:
Branch Support:
charts/tooljet/, gh-pages: root)4. Real Deployment Testing Workflow (
.github/workflows/helm-deploy-test.yml)Triggers:
Testing:
Benefits
Immediate
Long-term
Testing
Local Validation ✅
helm lint charts/tooljet --strict- PASSEDhelm install --dry-run- PASSEDhelm template- PASSED (668 lines rendered)Workflows Tested ✅