Bundle all sources together #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This feels hacky to me. A git clone with submodules is such a standard operation that it should be fine without an extra indirection. I can freshly clone locally without issue -- and the nix package which also does a recursive clone behind the scenes builds fine as well. I also never heard of someone installing via AUR having a problem (recursive clone as well). Let's wait a bit and try the flatpak build again later. If it stays broken, we can still revisit this, I suppose. 😅 Thanks for looking into it in any case! |
Owner
|
Resolved elsewhere. (Incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be nice to have a bundle of all sources (including submodules).
This moves downstream issues (flatpak build) upstream :)