Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add information about ak135.h5 in 1_crust1.0_ak135_model.py#53

Merged
xumi1993 merged 8 commits intodevelfrom
devel_jc
Nov 27, 2025
Merged

add information about ak135.h5 in 1_crust1.0_ak135_model.py#53
xumi1993 merged 8 commits intodevelfrom
devel_jc

Conversation

@JingChen-Thu
Copy link
Contributor

@JingChen-Thu JingChen-Thu commented Nov 26, 2025

Information of ak135.h5 has been added.

@xumi1993 xumi1993 requested a review from Copilot November 26, 2025 05:12
Copilot AI reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation comments to explain the structure and source of the ak135.h5 file used in the script. The change provides helpful context for users about the dataset format and references the original scientific publication where a text version of the model can be found.

  • Added descriptive comments explaining the three-column structure of the ak135.h5 dataset (depth, Vp, Vs)
  • Included citation to Kennett et al. (1995) paper as a reference for the ak135 model

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@xumi1993
Copy link
Member

xumi1993 commented Nov 27, 2025 •
edited
Loading

@JingChen-Thu

I made some changes on 519416c. Some built-in functions in PyTomoATT is updated with pure Python functions

  • gaussian_filter -> am_processed.smooth: this is a new feature in PyTomoATT v0.2.10 or later.
  • am_combined.copy(): the ATTModel class supports the deep copy method. No need to create a new instance and copy vel to the new one.

@JingChen-Thu
Copy link
Contributor Author

JingChen-Thu commented Nov 27, 2025

@JingChen-Thu

I made some changes on 519416c. Some built-in functions in PyTomoATT is updated with pure Python functions

  • gaussian_filter -> am_processed.smooth: this is a new feature in PyTomoATT v0.2.10 or later.
  • am_combined.copy(): the ATTModel class supports the deep copy method. No need to create a new instance and copy vel to the new one.

Received, I will use Pytomoatt to do the deep copy. Thanks for this suggestion.

@JingChen-Thu
Copy link
Contributor Author

JingChen-Thu commented Nov 27, 2025

@JingChen-Thu

I made some changes on 519416c. Some built-in functions in PyTomoATT is updated with pure Python functions

  • gaussian_filter -> am_processed.smooth: this is a new feature in PyTomoATT v0.2.10 or later.
  • am_combined.copy(): the ATTModel class supports the deep copy method. No need to create a new instance and copy vel to the new one.

I saw that you have done the revision. Thanks for reviewing it. Glad to see these revisions.

@xumi1993 xumi1993 merged commit 5eb2a3d into devel Nov 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@xumi1993 xumi1993 xumi1993 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JingChen-Thu @xumi1993 @mnagaso

Comments