ver1.1.2: fix near zero value in domain decomposed kernel#63
Merged
JingChen-Thu merged 11 commits intomainfrom Dec 11, 2025
Merged
ver1.1.2: fix near zero value in domain decomposed kernel#63JingChen-Thu merged 11 commits intomainfrom
JingChen-Thu merged 11 commits intomainfrom
Conversation
xumi1993
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a serious bug. At least two users have reported encountering it
In the previous version, when using multiple subdomains, the maximum value of kernel is computed within each subdomain. However, the correct value should be computed across all subdomains.
As a result, if the kernel in one subdomain is near zero, the code will incorrectly terminate.
This update fix this bug.