-
Notifications
You must be signed in to change notification settings - Fork 1
Fix clippy lints and add pre-commit hooks #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just commenting here to say that I've seen the PR, but haven't had a chance to review. I will do so as soon as I can! |
Utagai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, it is a little embarrassing to see some of my earliest Rust code from way back when. Thanks for going through and fixing/cleaning up a bunch of stuff. I put a few comments, but I don't think any of them are major.
Utagai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the recent changes.
The last things would be:
- See my comment about
_quotation; we should see if we can just remove that variable if its not doing anything useful. - Regarding
tarpaulin, I'd see if you can figure out what the situation there is... ideally, we can just remove the lint rule and be fine, but if there's issues without that rule we should understand why.
This PR looks basically great to me minus the two items above, and both of those items are not dealbreakers.
For your information, I will be away on travel until 9/25. My responses in this PR may be delayed.
Utagai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, but this looks great. Thanks!
It was previously failing in this github workflow job.