Axial symmetry fixes for BlocksOnCylindrical #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locksOnCylindrical axially symmetric.
|
Could you add a note to release_6.2.htm, as well as the tiny comments on the scanner definition in the |
KrisThielemans
requested changes
Jun 25, 2024
|
Projecting a symmetric cylinder with NeuroLF geometry gives only floating point level differences in symmetry (last plot is first axial half minus flipped second axial half of a viewgram): |
KrisThielemans
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Fix axial scanner downsampling and correct handling of gaps to make BlocksOnCylindrical axially symmetric.
Testing performed
See before and after in associated issue: #1465
Related issues
Fixes #1465
Relates to #1291
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)