[v1.5.2] Maintenance release #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a maintenance update to streamline installation and compatibility across Python versions. No substantive changes to the code.
PyTables dependency
This PR caps PyTables at
<3.6insetup.pyfor older versions of Python. PyTables 3.6 was released last week, dropping support for Python 2.7 and without binaries for Python 3.5. This seems not to be specified correctly in the metadata, though, sopip install tablesis broken on those platforms. Specifying the prior version allows Orca installation to continue working.Earlier this year, the last PyTables release caused problems for us as well -- it broke Pip installation across the board for several days. So I'm proposing that we block future PyTables updates from Orca environments until explicitly testing them. We can do this by capping PyTables at
<3.7for current versions of Python.Platform support
This PR also streamlines the Travis script. Pip installation and tests are running fine in Python 2.7, 3.5, 3.6, and 3.7. Installation doesn't work yet in Python 3.8 because we're waiting on PyTables binaries.
Other installation cleanup
pep8checks withpycodestyleez_setupbootstrappingTo do before merging