Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

d3xter666
Copy link
Member

This change continues the efforts from #1132 and enhances it by enabling vitepress build of the documentation.

JIRA: CPOUI5FOUNDATION-899

@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 037ceae to 31934ec Compare October 10, 2025 11:37
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from 8961b0d to 7a2ce4f Compare October 10, 2025 11:39
@d3xter666 d3xter666 requested a review from a team October 10, 2025 11:41
@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 64066ac to f3a5128 Compare October 14, 2025 06:51
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch 2 times, most recently from 6afdfe1 to 36c75f1 Compare October 14, 2025 11:02
@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 0107968 to af5446d Compare October 14, 2025 12:27
Base automatically changed from feat-create-docsumentation-package to main October 14, 2025 12:34
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from 7d5eba8 to 8beda5d Compare October 14, 2025 12:38
@d3xter666 d3xter666 requested a review from RandomByte October 14, 2025 13:08
@d3xter666 d3xter666 requested a review from a team October 16, 2025 06:56
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from c1e36b7 to a934f2a Compare October 20, 2025 09:48
@maxreichmann
Copy link
Member

/pages/CLI.html returns a 404.
It is referenced multiple times such as in the sidebar or in /pages/GettingStarted.html as "Next page"

@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from a934f2a to c1e36b7 Compare October 21, 2025 06:25
@d3xter666
Copy link
Member Author

/pages/CLI.html returns a 404. It is referenced multiple times such as in the sidebar or in /pages/GettingStarted.html as "Next page"

The CLI page must be generated via the npm run generate-cli-doc script in the root of the monorepo

@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from d0c7ac3 to 5311640 Compare October 21, 2025 08:37
@maxreichmann
Copy link
Member

maxreichmann commented Oct 21, 2025

Remark 1:
Wouldn't it make sense to move all the migration guide files from packages/documentation/docs/updates to the general pages directory packages/documentation/docs/pages?
We would then have all files in a combined directory and this would fix some 404 linkings e.g. of the button "Migrate to v4" on Home.html.

Remark 2:
These migration guide files contain wrongly formatted info/warning/success elements which have to be replaced.
e.g.:
image

  • For !!! tip, we can use ::: tip [...] ::: and remove the indendation
  • the same works for !!! warning
  • for !!! success, we have to find a different alternative

Since those files haven't been touched in this PR yet, I couldn't create a GH code suggestion.

@d3xter666
Copy link
Member Author

We would then have all files in a combined directory and this would fix some 404 linkings e.g. of the button "Migrate to v4" on Home.html.

My intention was to do the cleanup in the next step, but now I have fixed the formatting and links.
Thanks!

@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from de2cb77 to e0aa321 Compare October 22, 2025 07:28
@maxreichmann
Copy link
Member

I really don't wanna be picky, but the last change regarding removing the quotes would need to be applied for every ::: occurrence where it is necessary 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants