Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

d3xter666
Copy link
Member

JIRA: CPOUI5FOUNDATION-1125

…flexBundle' property to the manifest.json (#1164)

JIRA: CPOUI5FOUNDATION-1125

---------

Co-authored-by: Christian Voshage <[email protected]>
@d3xter666 d3xter666 requested a review from a team October 21, 2025 12:07
@flovogt
Copy link
Member

flovogt commented Oct 21, 2025

should we use "feat(packages/builder):" as commit message header?

@matz3
Copy link
Member

matz3 commented Oct 22, 2025

We should update https://github.com/UI5/cli/blob/main/docs/Guidelines.md, as it still mentions the OpenUI5-style commit message guidelines. There, we should document how we want to use the scope part.

@matz3
Copy link
Member

matz3 commented Oct 22, 2025

Also, we still don't have any conventional commit lint checks.

@d3xter666
Copy link
Member Author

We should update https://github.com/UI5/cli/blob/main/docs/Guidelines.md, as it still mentions the OpenUI5-style commit message guidelines. There, we should document how we want to use the scope part.

We should update https://github.com/UI5/cli/blob/main/docs/Guidelines.md, as it still mentions the OpenUI5-style commit message guidelines. There, we should document how we want to use the scope part.

Also, we still don't have any conventional commit lint checks.

Shall we address all those here? Or maybe this change can wait until we have decided on those?

@matz3
Copy link
Member

matz3 commented Oct 22, 2025

It should be tackled as part of CPOUI5FOUNDATION-1152. I would prefer to wait on that before merging this change. It doesn't block a release of the feature in v4. We just need to ensure that this PR is merged before we produce the first v5 release.

@matz3
Copy link
Member

matz3 commented Oct 23, 2025

The commit message references the original PR from ui5-builder "1164", which is now here linked to a different PR with the same number. The number should be removed from the title and a full link should be added to the commit message body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants