ci: Add test matrix (Node 20, 22, 24 on Linux / macOS / Windows) #1168
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update checkout action to latest version.
d3xter666
reviewed
Oct 22, 2025
| run: npm ci | ||
|
|
||
| - name: Run unit tests | ||
| run: npm run unit |
There was a problem hiding this comment.
Is there a reason for running just the unit tests, but not npm run test?
There was a problem hiding this comment.
We already run all steps from "npm test" in the general workflow: https://github.com/UI5/cli/blob/main/.github/workflows/github-ci.yml
The matrix is intended to cover potential issues with the unit tests on different platforms / Node versions.
Are there some additional checks that you think should be run within the matrix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update checkout action to latest version.