C++17: use inline globals for StaticObjects #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dff4324 to
b9238fc
Compare
|
Made a small mistake with |
|
Interesting. It seems like Clang 5 has a bug with inline variables that was fixed in later versions. It seems that there are two ways forward: we could remove the test or we could adjust the |
This prevents multiple definition errors in Clang, and also stops dllexporting functions with internal linkage. Degrades gracefully when C++17 is not present. Fix USCiLab#595 Fix USCiLab#652 Fix USCiLab#582 Fix USCiLab#643
b9238fc to
06696d0
Compare
|
Fix applied to exclude Clang 5.x from C++17 features |
|
Very nice fix, thank you! Any chance to get this merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents multiple definition errors in Clang,
and also stops dllexporting functions with internal
linkage. Degrades gracefully when C++17 is not
present. Tested on MSVC 2017 and LLVM on Windows.
Also fix a few
_MSC_VERtests to only apply for non-recentversions of MSVC 2017 and below.
Fix #595
Fix #652
Fix #582
Fix #643