Fixed compile error related to std::string in JSONOutputArchive #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSONOutputArchive expected an std::string param to be passed saveValue(). This caused the compilation to fail when the more generic std::basic_string was passed and not an std::string. This fix changes the signature of saveValue to expect an std::basic_string
JSONOutputArchive expected an std::string param to be passed to loadValue(). This caused the compilation to fail when the more generic std::basic_string was passed and not an std::string. This fix changes the signature of loadValue to expect an std::basic_string
Author
|
Hello @AzothAmmo, could this simple fix be added to the v1.3.1 release? |
|
I am also affected by this compilation issue, would this fix be included in the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONOutputArchive expected an std::string param to be passed saveValue().
This caused the compilation to fail when the more generic std::basic_string was passed and not an std::string.
This fix changes the signature of saveValue to expect an std::basic_string