Boundary parms #139
Merged
Boundary parms #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cwsimmon
commented
Oct 17, 2025
- Renamed penalize_aic_on_boundary in pybmds and penalizeAIC in bmds core to count_all_parameters_on_boundary and countAllParmsOnBoundary.
- Adjusted all associated logic to match the new property names
- Modified any calculations based on bound parameters or number of estimated parameters to reflect user choice
|
PR looks good to me, I was able to show how the count_all_parameters_on_boundary variable impacts modeling results in the dichotomous and continuous notebooks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.