-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Is your feature request related to a problem? Please describe:
TADA_CalculateTotalNP calculates total N and P and carries over some metadata for the new rows created in the output. All relevant fields are not currently included.
Describe the solution you'd like:
The TADA fields and some of the metadata is translated over, but not all the relevant fields. Here’s a list of metadata fields that would be useful to have carried over in the output:
• OrganizationIdentifier
• OrganizationFormalName
• CountryCode
• StateCode
• CountyCode
• HUCEightDigitCode
• MonitoringLocationName (is there already)
• MonitoringLocationTypeName
• MonitoringLocationDescriptionText
• MonitoringLocationIdentifier (is there already)
These were suggested by TADA Working Group member: Kristen Swedberg. Suggest to reach out to her for testing once issue is complete.
Reminders for TADA contributors addressing this issue:
New features and/or edits should include all the following work:
-
Create or edit the function/code.
-
Document all code using line/inline and/or multi-line/block comments
to describe what is does. -
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues. -
Create or edit the function documentation. Include working
examples. -
Update or add the new functionality to the appropriate vignette
(or create new one). -
If function/code edits made as part of this issue impact other
functions in the package or functionality in the shiny app, ensure
those are updated as well. -
Run TADA_UpdateAllRefs(), TADA_UpdateExampleData(), styler::style_pkg(),
devtools::document(), and devtools::check() and address any new notes or
issues before creating a pull request. -
Run more robust check for releases: devtools::check(manual = TRUE,
remote = TRUE, incoming = TRUE)