Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cristinamullin
Copy link
Collaborator

@cristinamullin cristinamullin commented Aug 12, 2025

This PR combines edits made in these 3 PRs for team review:

  1. Creates two new functions: TADA_CreateUseAURef and TADA_CreateWaterUseRef: Use to AU reference table #623
  • Assigns ATTAINS Use Names to each AU in a user's WQP/TADA dataframe
  • TADA_CreateWaterUseRef is a helper function to help assign ATTAINS Use to new/updated AUs
  1. New Module 2/Geospatial Workflow: New Module 2/Geospatial Workflow #629
  • A functional draft of TADA_CreateAUMLRef
  • An example Module 2 workflow (see vignette called ExampleMod2Workflow.rmd)
  1. Bug fixes & maintenance: bug fix and adding recent updates to vignettes #624

wokenny13 and others added 30 commits June 16, 2025 16:03
Excel conditional formatting update
handle empty column type for joining data format
Manual additional of additional alias between ATTAINS ParameterName and WQP CharacteristicName
Changed to "Not Applicable for Analysis" as the drop down value for TADA_CreateParamRef
Some code styling changes and arranged drop down by ascending.

Do we want the "Not applicable for Analysis" option to show up in the top or bottom in Excel?

We mentioned top but it seems like clicking on the drop down will show bottom entries first
Changed offset to 100 for ATTAINS geospatial webservices
Renamed to consistent column names between helper function and spatial crosswalk with AU spatial summary.
Added Char, spec, frac to CriteriaMethods.

Reformat excel file
Changed column name to ATTAINS.WaterType throughout crosswalk tables.

Edited format of excel spreadsheet outputs.
Edit to required columns.

DepthProfile fix incorporated
…f workflow

Reordered workflow of functions and changed function name

New order:
TADA_CreateWaterUseRef -> TADA_CreateUseAURef

Users should run these functions as part of Module 2 now.

These functions aim to help with assigning Uses to AU once sites have been joined to AUs.
This PR focuses on assigning ATTAINS Use Name to each AU.

There are two functions in this PR: TADA_CreateUseAURef and TADA_CreateWaterUseRef

TADA_CreateWaterUseRef is a helper function to help assign ATTAINS Use to new/updated AUs.

This function excludes other Mod 3 functions for the time being.
Used a sample data input for testinf and forgot to change back to sitesAURef
Added global variables to utilities

Fixed Function documentation in CreateWaterUseRef

Ran styler and word list maintainence
@cristinamullin cristinamullin merged commit ee2814b into develop Aug 20, 2025
0 of 7 checks passed
@cristinamullin cristinamullin deleted the combined-review branch August 20, 2025 15:19
@cristinamullin cristinamullin restored the combined-review branch August 20, 2025 19:04
@cristinamullin cristinamullin deleted the combined-review branch August 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants