473 tada twocharacteristicscatterplot legend should not include fraction andor speciation if they are na #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NA no longer showing in legend, but still shown in axis label
NAs are now removed from Y axis labels too
Collaborator
|
Yes, good idea! |
…end-should-not-include-fraction-andor-speciation-if-they-are-na
…end-should-not-include-fraction-andor-speciation-if-they-are-na
…end-should-not-include-fraction-andor-speciation-if-they-are-na
cristinamullin
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this for legend and y axis. I think a long term solution that could be applied here and other places is to create an internal function that uses stringr::str_remove_all with common iterations of NA found in TADA.ComparableDataIdentifier, etc. that could be used in many of the current and future figure functions.
If you think this sounds like a good idea, @cristinamullin , I can write up an issue for it.