471 tada convertresultunits is overwriting tadamethodspeciationname with na #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on selecting required columns from usgs ref to facilitate assigning speciation correctly
Added a column with just the base unit code to usgs ref to facilitate custom conversion
Work to account for method speciation from wqx/usgs results correctly in TADA_CreateUnitRef
Correctly assigns method speciation name for usgs results for user supplied and tada ref
Changes to incorporate method speciation from create unit ref
Length error, not corrected yet
…g-tadamethodspeciationname-with-na
Not complete yet, still issues with units
Detection limit TADA units are now being shown correctly (no speciation in units)
Added apply autoclean = TRUE for UT nutrient example. Updated all example data sets to reflect changes in convert result units which affect autoclean.
Updated comparable ID in vignette for assessment unit use case due to changes in comparable data idea resulting from convert result units changes.
Updates to examples due to changes in TADA.ComparableDataIdentifier
Expanded list of joining columns (include method speciation) to prevent creation of new columns
Had to add TADA.MethodSpeciationName to TADA_CreateUnitRef in order to have convert result units work
Added additional condition to check is ref is a data frame before checking for ref equals tada or wqx
Collaborator
Author
|
@wokenny13 - if you have time to take a look at these changes and run TADA_ConvertResultUnits on a few example data sets that would be great. Thanks! |
Reference correct branch
Simplified test.
Potential fix for TADA_FieldValuesPie
Needed update after unit conversion changes
Collaborator
Author
|
@wokenny13 - this is ready for review. |
Collaborator
|
Ran through a few example datasets for different states and for both Nitrogen and Phosphorus. The updates have fixed the overwriting issues for these examples that I ran. |
…g-tadamethodspeciationname-with-na
Collaborator
Author
|
@wokenny13 - thanks for running some example data sets. The checks are re-running due to a new vignette I merged into the develop branch. Once all those checks have passed, I will merge in the unit conversion changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to fix overwrite of tada method speciation name with na. In order to get this to work correctly, I had to add TADA.MethodSpeciationName as a column in the output of TADA_CreateUnitRef.