472 speciation included in units #493
Conversation
Method detection limit units now convert correctly without speciation (TADA cols)
…/USEPA/EPATADA into 472-speciation-included-in-units
The DO/DO saturation related code in TADA_Autoclean is only run if DO results (identified by CharacteristicName) are present in the data set
Fixed accidental many-to-many relationship which was adding rows and causing TADA_AutoClean to fail for selected data sets
|
Details on the original issue here: #472 Thanks for reviewing - as part of your review, please test TADA_AutoClean and TADA_ConvertResultsUnits with some random data sets to make sure that no additional rows are added and that TADA result unit columns contain values that make sense. |
cefergus
left a comment
There was a problem hiding this comment.
I think the changes look good. I ran the TADA_AutoClean function on a few WQP datasets (Upper Sioux, USGS MN, and Rogue River Volunteer group) and it ran as expected. It's hard for me to dig into the function code without having a better understanding of the various objects - but I think it makes sense. Something I noticed in the current UnitConversons.R is that L262-265 describe Speciation in USGS result units - this text may need to be revised to reflect the changes?
|
@ Thanks for the review and testing, @cefergus. I will take a look at the text you identified in L262-265. |
Corrected bug - speciation no longer appearing in TADA method detection limit units