292 nearby sites #497
292 nearby sites #497
Conversation
|
@hillarymarler The automated checks that run when a pull request is made are continuing to fail, but I have run just about all the tests suggested in the TADA Package cheat sheet and everything looks OK for me locally. Let me know if there is something specific I can do to get this ticket closed. Thank you! |
|
@renaemyers - I just merged some changes in to the develop branch that were related to some of the consistent errors we've been seeing related to vignettes/articles. Hopefully that will address the issues you have been seeing as well. If not, I will take another look at the error messages for this branch today and make any changes needed. |
Minor formatting changes in Figures.R and Utilities.R
hillarymarler
left a comment
There was a problem hiding this comment.
@renaemyers - I was able to resolve the check errors. Some were taken care of due to my other updates related to vignettes. The other was related to the use of "[" and "]" in the function documentation as these have specific meaning in the roxygen2 package for use in linking to functions/objects within the package.
The mapping function looks great, so I will approve and merge in the changes. In the long term, we may want to make colors for the markers consistent with the rest of the TADA color palette (use TADA_ViewColorPalette to see it). I know that makeAwesomeIcon() has a set number of marker colors and as we have not yet finalized the color palette, updating this does not need to be a priority right now.
No description provided.