I need to update branch refs in vignettes in order to pass checks. I will do that on Monday,

@wokenny13 and @cefergus - this is now passing checks and ready for review.

Using the example with loading the example dataset

data(Data_Nutrients_UT)

does the ExampleData.R re-run the example datasets with any of the changes that are made with applyautoclean done to TADA_SimpleCensoredMethods and TADA_ConvertResultUnit?

After running

`Data_Nutrients_UT2 <- TADA_SimpleCensoredMethods(Data_Nutrients_UT)
TADA_FieldValuesTable(Data_Nutrients_UT2, field = 'TADA.ComparableDataIdentifier')'

I get two fields that would still have NA for the units, is this expected as a potential output?:

Or is it required to re-run the example data pull to reflect the changes?

Using the example with loading the example dataset

data(Data_Nutrients_UT)

does the ExampleData.R re-run the example datasets with any of the changes that are made with applyautoclean done to TADA_SimpleCensoredMethods and TADA_ConvertResultUnit?

After running

`Data_Nutrients_UT2 <- TADA_SimpleCensoredMethods(Data_Nutrients_UT) TADA_FieldValuesTable(Data_Nutrients_UT2, field = 'TADA.ComparableDataIdentifier')'

I get two fields that would still have NA for the units, is this expected as a potential output?:

Or is it required to re-run the example data pull to reflect the changes?

@wokenny13 - the missing units are related to results where there is no unit (or value) provided for the detection quantitation limit. So even when TADA_SimpleCensoredMethods is run, there is no unit/value to pull. It is strange to see - maybe something we should bring up with WQP team.

Working off the example you provided, see:
subset_na_unitcode <- Data_Nutrients_UT2 %>% dplyr::filter(is.na(TADA.ResultMeasure.MeasureUnitCode))

I figured something along the lines of that was the case, but just wanted to confirm. Do these results get flagged at all? It represents a small portion of the dataset, but might be good to bring up to the WQP team.

I ran a test dataset, but I seem to still be seeing speciation name appearing at the end where the units should be.

datatest <- TADA_DataRetrieval(statecode = 'FL', startDate = '2024-01-01', endDate = '2024-06-30', characteristicName = c('Ammonia','Nitrate','Nitrogen'))
unique(datatest$TADA.ComparableDataIdentifier)
datatest2 <- TADA_SimpleCensoredMethods(datatest)
datatest3 <- TADA_ConvertResultUnits(datatest)
unique(datatest2$TADA.ComparableDataIdentifier)
unique(datatest3$TADA.ComparableDataIdentifier)

Thanks for catching this - I had made some minor changes related to issues happening with NAs in an example data set. Now if there are NOT NAs in certain columns there are issues it seems. I'll work on an update to fix this new bug.

I made some major changes to TADA_CreateUnitRef and TADA_ConvertResultUnits. I believe both are working as expected now and as a bonus, the code for those two functions is now much more concise.

I re-ran your FL example and this was the result for unique TADA.ComparableDataIdentifier:

I made some major changes to TADA_CreateUnitRef and TADA_ConvertResultUnits. I believe both are working as expected now and as a bonus, the code for those two functions is now much more concise.

I re-ran your FL example and this was the result for unique TADA.ComparableDataIdentifier:

This is good to hear! I will take a look and review tomorrow

@wokenny13 - looks like I've got a couple of check errors to work through first, so you can wait until I've got those resolved.

@wokenny13 - check errors have been resolved.