Good catch Kenny. We've run into similar issues before and applied a similar approach to resolve. We changed NA to "NA - Not Available" (character).

Should we convert to "NA - Not Available" here as well for consistency with other TADA functions?

Keeping any NA changes to "NA - Not Available" for consistency sounds like it would be good.

In general, does storing a value as a logical/missing NA versus a character NA make any difference in speed/performance/memory?

Best spot to handle this change?

I think dupsdata convert the logical NA for TADA.MonitoringLocationIdentifier to a character in this chunk of the code in TADA_FindPotentialDuplicatesMultipleOrgs. In this case, since a full join is used at the end of the code, I believe it would require then changing "NA" found in dupsdata to "NA - Not Available"

dupsdat <- dupsdat %>% dplyr::rename(SingleNearbyGroup = TADA.MonitoringLocationIdentifier) %>% dplyr::mutate( TADA.MonitoringLocationIdentifier = paste(SingleNearbyGroup, sep = ","), TADA.ResultSelectedMultipleOrgs = ifelse(ResultIdentifier %in% duppicks$ResultIdentifier, "Y", "N") ) %>% dplyr::select(-SingleNearbyGroup)

Or would we want to make edits to NA value in lines 841 under TADA_FindNearbySites() where

if (!"TADA.MonitoringLocationIdentifier" %in% colnames(.data)) { .data$TADA.MonitoringLocationIdentifier <- NA }

@wokenny13 - is this ready for review?

@hillarymarler

Good catch Kenny. We've run into similar issues before and applied a similar approach to resolve. We changed NA to "NA - Not Available" (character).

Should we convert to "NA - Not Available" here as well for consistency with other TADA functions?

I will work on converting it to "NA - Not Available" for consistency. I will let you know when I get this finished and for it to be reviewed then

Sounds great - thank you!

@hillarymarler this is ready for review