534 dataset growing mt example #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix many-to-many issue in det unit conversions
wokenny13
approved these changes
Oct 22, 2024
Collaborator
wokenny13
left a comment
There was a problem hiding this comment.
I ran through several dataset tests, and everything looks like it is running as it should now.
Collaborator
Author
|
Thanks @wokenny13 - I am going to go ahead and merge this since it was a user reported bug and they're eager to get back to work! We can discuss if additional updates are needed with the rest of the team later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to TADA_ConvertResultUnits to prevent the dataset from growing when converting result units or using autoclean.
The problem as many-to-many relationships between detection limit units and the conversion reference. Adding "TADA.DetectionQuantitationLimitMeasure.MeasureUnitCode" as another joining column prevents many-to-manys at this join.