397 range check bug #540
Merged
397 range check bug #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtered unit.ref to include only accepted rows
Closed
Included max value in range check, commented out problematic test (will need to be fixed with TADA_FindNearbySites updates) and commented out timezone columns as required in DataDiscoveryRetrieval test
cristinamullin
approved these changes
Nov 7, 2024
Collaborator
|
@hillarymarler this all look great & is ready to merge once the checks complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates both TADA threshold functions now that validation table has been updated to ensure that there is only one min/max for each characteristic/source/value.unit combination.