Thanks to visit codestin.com
Credit goes to github.com

Skip to content

556 test failure when tada randomtestingdata provides no results #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristinamullin merged 3 commits into from
Dec 23, 2024
Merged

556 test failure when tada randomtestingdata provides no results #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
883f23a
Update Utilities.R
hillarymarler Dec 17, 2024
2494bbd
Update Utilities.R
hillarymarler Dec 17, 2024
7880454
Update TADA_RandomTestingData.Rd
hillarymarler Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions R/Utilities.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,9 @@ TADA_GetUniqueNearbySites <- function(.data) {
#'
#' Retrieves data for a period of time in the past 20 years using
#' TADA_DataRetrieval. This function can be used for testing functions on
#' random datasets.
#' random datasets. Only random data sets with 10 or more results will be returned.
#' If a random dataset has fewer than 10 results, the function will automatically
#' create another random WQP query until a df with greater than 10 results is returned.
#'
#' @param number_of_days Numeric. The default is 1, which will query and retrieve
#' data for a random two-day period (e.g.startDate = "2015-04-21",
Expand Down Expand Up @@ -943,20 +945,23 @@ TADA_GetUniqueNearbySites <- function(.data) {
#' df <- TADA_RandomTestingData(number_of_days = 5, choose_random_state = TRUE, autoclean = FALSE)
#' }
#'
TADA_RandomTestingData <- function(number_of_days = 1, choose_random_state = FALSE, autoclean = TRUE) {
while (TRUE) {
TADA_RandomTestingData <- function(number_of_days = 1, choose_random_state = FALSE,
autoclean = TRUE) {

get_random_data <- function(ndays = number_of_days, state_choice = choose_random_state,
ac = autoclean) {
# choose a random day within the last 20 years
twenty_yrs_ago <- Sys.Date() - 20 * 365
random_start_date <- twenty_yrs_ago + sample(20 * 365, 1)
# choose a random start date and add any number_of_days (set that as the end date)
end_date <- random_start_date + number_of_days
end_date <- random_start_date + ndays

if (choose_random_state == TRUE) {
if (state_choice == TRUE) {
load(system.file("extdata", "statecodes_df.Rdata", package = "EPATADA"))
state <- sample(statecodes_df$STUSAB, 1)
}

if (choose_random_state == FALSE) {
if (state_choice == FALSE) {
state <- "null"
}

Expand All @@ -966,7 +971,7 @@ TADA_RandomTestingData <- function(number_of_days = 1, choose_random_state = FAL
statecode = state
))

if (autoclean == TRUE) {
if (ac == TRUE) {
dat <- TADA_DataRetrieval(
startDate = as.character(random_start_date),
endDate = as.character(end_date),
Expand All @@ -975,19 +980,26 @@ TADA_RandomTestingData <- function(number_of_days = 1, choose_random_state = FAL
)
}

if (autoclean == FALSE) {
if (ac == FALSE) {
dat <- TADA_DataRetrieval(
startDate = as.character(random_start_date),
endDate = as.character(end_date),
statecode = state,
applyautoclean = FALSE
)
}

if (nrow(dat) > 0) {
return(dat)
return(dat)
}

verify_random_data <- function() {
df <- get_random_data()
while(nrow(df) < 10) {
df <- get_random_data()
}
return(df)
}

verify_random_data()
}

#' Aggregate multiple result values to a min, max, or mean
Expand Down
4 changes: 3 additions & 1 deletion man/TADA_RandomTestingData.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading