-
Notifications
You must be signed in to change notification settings - Fork 23
Mini Release #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini Release #578
Conversation
Potential fix for Field table bug
I included a few spots where TADA.MonitoringLocationIdentifier or TADA.MonitoringLocationType may be appropriate but if they don't see appropriate for change, please feel free to revert.
…er-in-tada_autoclean
Updates to nearby sites
…er-in-tada_autoclean
…er-in-tada_autoclean
…er-in-tada_autoclean
…er-in-tada_autoclean
…er-in-tada_autoclean
remove TADA_FindPotentialDuplicatsMultipleOrgs tests and examples, takes too long
Url and url checker updates
update dependencies in desc, fix long examples
documentation update to match URL change
remove data call
|
For TADA_FindNearby sites, the change that is causing the much longer run time is the inclusion of fetchNHD to only group sites that are within the same catchment. I have not tried this yet, but it would be possible to use the adjacency matrix approach only using the buffer distance, without grouping by catchment. We could offer users the option as to whether they want to group by catchment or not and explain that grouping by catchment will result in a longer run time. I can make the updates for whatever route we choose. That is a potential option to prevent returning multiple groups for a single monitoring location and reduce the current run time. So I think the three options are really: 1) incorporate catchments (longer run time) , 2) rely only on buffer distance for grouping (shorter run time) or 3) users decide if they want to incorporate catchments when finding nearby sites. |
This reverts commit bb9bc2a.
|
There are occasional test failures of ('test-ResultFlagsIndependent.R:137:3'): QC results are not flagged as Continuous ── I am working on troubleshooting this one. Update: I updated the test to be more inclusive of allowable values in TADA.ActivityType.Flag (anything that is not one of the QC variations is acceptable) |
updated test to check for all QC options and fail if it finds them, previous test was too restrictive as it expected only "Non_QC" as a valid TADA.ActivityTpye.Flag
hillarymarler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Are there any specific functions you'd like me to test?
| EPA304A.PollutantName, ATTAINS.ParameterName | ||
| ) %>% | ||
| dplyr::arrange(organization_identifier, TADA.CharacteristicName) %>% | ||
| dplyr::arrange(organization_identifier) %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also arrange by TADA.ComparableDataIdentifier so it is easier for users to find a specific row?
|
I am still seeing occasional failures of the continuous/QC results test. They seem to be related to TADA_RandomTestingData return empty data frames (which it should not do), so I'm taking a look at that now. |
Overview
Additional info
A few notes:
Closes #361, closes #427, closes #345, closes #159