A few updates to improve TADAShiny deployment #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cristinamullin
commented
Mar 17, 2025
- Fixes images in readme and Mod 1 vignette
- Reorganizes code in .r files
- Updates "key" columns for filtering in TADA_FieldCounts
Fixes images in readme and Mod 1 vignette, reorganizes code in .r files, update "key" columns for filtering in TADA_FieldCounts
hillarymarler
requested changes
Mar 17, 2025
Collaborator
hillarymarler
left a comment
There was a problem hiding this comment.
These changes look good to me. I can update the continuous data flagging test once we decide on the best course of action for that. (Marked this as "request changes" as a reminder to fix that test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.