Add new geospatial vignette #581
Conversation
|
This looks good - I see a couple placeholders I could add to - would it be helpful to fold that in now prior to merging PR or were you thinking merge and then flesh out over time? |
@mhweber I think it would be helpful to add that in now before merging if you have time? I still need to troubleshoot the last section as well. Maybe we could aim to merge it in by the end of the day Thursday? I am considering offering this as a virtual workshop to the TADA Working Group in May. Would you be interested in helping present? |
|
@cristinamullin sounds good! |
| force = TRUE) | ||
| library(EPATADA) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Assume want to leave the ref=develop and get rid of the ref=geospatial-vignette when merging?
There was a problem hiding this comment.
I think in most of other vignettes, we leave this chunk for future dev purposes and set eval = F. Then set eval = T for the develop branch install.
| # applyautoclean = TRUE | ||
| # ) | ||
|
|
||
| GreenBay_FoxRiver <- NMCWorkshopData::GreenBay_FoxRiver |
There was a problem hiding this comment.
vignette doesn't show installing NMCWorkshopData data package - should we get rid of that line and uncomment the normal way of pulling data (since data package was a convenience for the workshop in case of no wifi connectivity?)
mhweber
left a comment
There was a problem hiding this comment.
@cristinamullin, @hillarymarler I made a few comments for the review and pushed a couple minor updates to geospatial-vignette. I can help add more at end but it's probably ready to merge into develop and could flesh out last placeholder section in next couple weeks?
Adds a new geospatial data integration vignette that can be used for a future workshop/training