Module 3 tada create param ref and tada create use param ref updates #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates DefineMagnitude in which is the dataframe users will define Magnitude Criteria components
Fixed some formatting with the DefineMagnitude output table and other Continued developments.
DefineMagnitude format has been updated. Minor bug fix in TADA_CreateParamRef() was fixed.
need to review logic in summary output and handling of empty column cases and how to best summarize impairments
Define Magnitude Excursion Summary
Summary of magnitude excursions edits with formatting and logic are also included in this commit.
Renamed paramUseRef argument to useParamRef
Removed duplicate TADA functions that were moved around from different branches.
Adding WaterType column and consider renaming of function.
New required argument inputs. WaterType column will be included in this output. ATTAINS.ParameterName column added as well. Users will need to specify unique spatial criteria for a Param-Use-WaterType during this function.
chunk size and blank space in URL handling
…-Updates' of https://github.com/USEPA/EPATADA into Module-3-TADA_CreateParamRef-and-TADA_CreateUseParamRef-Updates
…-Updates' of https://github.com/USEPA/EPATADA into Module-3-TADA_CreateParamRef-and-TADA_CreateUseParamRef-Updates
Removed rATTAINS dependency and replaced use cases with rExpertQuery Removed irrelevant Example dataframes in this PR Modified Mod3a vignette
explicitly named each dataframe to reflect what each dataframe is showing from each TADA mod 3 function and its arg inputs. Fixed a small bug in flagging column for TADA_CreateUseParamRef Removed EPA304a section as this was moved to only be shown in the final CriteriaMethods table (still in draft)
‘Data_Nutrients_UT_GetATTAINS’ ‘Data_WV_Mod1_Output_GetATTAINS’ as these are not relevant to this PR
Collaborator
Author
|
I updated the vignette to make the names of the crosswalk example data frames functionality more explicit and fixed some small flagging bugs so that everything should be working as intended. I kept the function names and argument input the same for now and we can consider more appropriate new names. We can also consider the flagging columns in both functions and see if they can be reworded in any way for better clarity. This should be in a good spot for a more final review now. |
color coded excel column values explicit arg input for excel = FALSE throughout
…ateUseParamRef-Updates
…ateUseParamRef-Updates
change fillBy to auto_assign in TADA_CreateParamRef
Collaborator
|
I changed fillBy to auto_assign in TADA_CreateParamRef for consistency. @wokenny13 I added one comment about the figures. Once that is addressed, this can be merged. Great work!! |
Changed title of mod 3 workflow images to WQP 'Analysis'
cristinamullin
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on the updates that have been made to TADA_CreateParamRef and TADA_CreateUseParamRef
(Next pull request will focus on the additional Spatial crosswalks and TADA_DefineCriteriaMethodology functions. Excluded those functions from this PR.)
In this PR please look through: