Fix consolidated depth and depth flag bug #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depth.count ==0 was inside depth.count>0, moved the if chunk outside of it. specified the NA as a character and numeric for TADA.DepthCategory.Flag and TADA.ConsolidatedDepth respectively.
Collaborator
|
I made a minor update in my commit. This seems to resolve the problem for cases in which no depth data is available. |
R/DepthProfile.R
Outdated
| } | ||
|
|
||
| if (depth.count == 0) { | ||
| print(paste0("TADA_FlagDepthCategory: checking data set for depth values. No results have depth values available. ", |
Collaborator
There was a problem hiding this comment.
Is paste needed here?
Suggested update:
print("TADA_FlagDepthCategory: No depth information was found in the dataset. The columns TADA.DepthCategory.Flag and TADA.ConsolidatedDepth are being added and populated with NA values.")
Collaborator
Author
There was a problem hiding this comment.
I removed the unnecessary paste, @cristinamullin. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a data set had no depth data available, the additional columns, TADA.DepthCategory.Flag and TADA.ConsolidatedDepth, were not added. This created problems in some workflows. This fix adds the two columns (filled with NA) when a data set has no depth data available.