Add new TADA_RenametoLegacy function and WQX 3.0 Migration vignette #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding RenametoLegacy function
Revised roxygen description of TADA_RenametoLegacy function
Closed
Collaborator
|
I also took a quick look at the existing WQXValidationService.Rmd and noticed this note to expand: |
hillarymarler
approved these changes
Aug 25, 2025
…-vignette' into WQX3_Crosswalk
update refs and example data, check spelling, run styler
handle cases where there is no applicable data
Collaborator
Author
Good catch. This was a placeholder. TADA now handles this in the nearby sites function, though it does not include an option to look for nearby sites only within the same organization (or across all). That might be a nice option to add as a function input. There are other parts of the vignette that need updating too. Creating a separate issue for this |
specify tidyselect::everything()
update TADA_BigDataHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.