-
Notifications
You must be signed in to change notification settings - Fork 23
Module 2 and Module 3: New/edited functions and example workflows #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can choose to edit a reference table and refresh Criteria and Methodology file as an iterative process. Each table is hierarchical. User must specify which table is being updated through the updateRef argument input.
more descriptive comments on function inputs in TADA_CreateParamRef
handling of Char, fraction and speciation of all combinations if a user has those columns.
summary of data compared to Criteria Methods with a rolling timestamp (draft)
TADA aggregted data frame scatterplot testing
This reverts commit feda29f.
Update R documentation
change siteRef to MLSummaryRef change sitesAURef to MLAURef
sitesAURef changed to MLAURef
This reverts commit f2a4f11.
update example data calls to include utils::
update Not Reviewed rows in WQXMeasureQualifierCodeRef.csv
criteria table excel definitions finished defining (needs review still) explicit call to testthat functions in test
suppresswarnings and other warning message handling for when they are expected warnings.
Look for maintenance-branch first, use default (develop) if that fails. Still commits to maintenance-branch either way. Checks are triggered when the branch has a PR.
set return_nearest = FALSE for MT Mod2 example
added text to clarify that in this example return_nearest = TRUE
cristinamullin
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Criteria and Methodology TADA Template