bug fix - user supplied ref does not match any mls in TADA df #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamullin
approved these changes
Oct 14, 2025
Contributor
Collaborator
|
@hillarymarler should the be joining on assessment unit ID? ══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-GeospatialFunctions.R:125:3'): TADA_GetATTAINS rejects invalid resolution values ──
Error in `dplyr::left_join(., distances_table, by = c("ResultIdentifier",
"assessmentunitidentifier"))`: Join columns in `y` must be present in the data.
x Problem with `ResultIdentifier` and `assessmentunitidentifier`.
Backtrace:
▆
1. ├─testthat::expect_error(...) at test-GeospatialFunctions.R:125:3
2. │ └─testthat:::expect_condition_matching(...)
3. │ └─testthat:::quasi_capture(...)
4. │ ├─testthat (local) .capture(...)
5. │ │ └─base::withCallingHandlers(...)
6. │ └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
7. ├─EPATADA::TADA_CreateATTAINSAUMLCrosswalk(...)
8. │ └─... %>% sf::st_as_sf() at EPATADA/R/GeospatialFunctions.R:1476:5
9. ├─sf::st_as_sf(.)
10. ├─dplyr::distinct(.)
11. ├─dplyr::left_join(...)
12. └─dplyr:::left_join.data.frame(., distances_table, by = c("ResultIdentifier", "assessmentunitidentifier"))
13. └─dplyr:::join_mutate(...)
14. └─dplyr:::join_cols(...)
15. └─dplyr:::check_join_vars(by$y, y_names, by$condition, "y", error_call = error_call)
16. └─rlang::abort(bullets, call = error_call) |
Collaborator
Author
|
I'll take a look. It may need to join on ATTAINS.AssessmentUnitIdentifier now. |
Collaborator
Author
|
I haven't been able to reproduce this error - that check has been passing when I run it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for an issue noted by Ben. Previously if a user-supplied au_ref did not contain any matches with monitoring locations in the TADA df, the function would stop and not complete its run. Now, this does not cause an issue and the function runs correctly and attempts to match all monitoring locations in the TADA df using the ATTAINS crosswalk and TADA_CreateATTAINSAUMLCrosswalk.