-
Notifications
You must be signed in to change notification settings - Fork 23
680 duplicate function tada aggregatemeasurements #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristinamullin
merged 7 commits into
develop
from
680-duplicate-function-tada_aggregatemeasurements
Oct 16, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cee9c00
Drop this function as it is also in Utilities.R
jbousquin e5b9259
Run CI tests/checks so results of changes (per commit) are easy to re…
jbousquin c0456b1
Update version in Utilities based on version that was in Transformations
jbousquin 21b3f32
Merge remote-tracking branch 'origin/develop' into 680-duplicate-func…
jbousquin 1d727c7
Add function back to Transformations.R and remove from Utilities.R be…
jbousquin 1cde1fd
Update docs
jbousquin 0993ec1
PR prep (don't need to run 2x)
jbousquin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this change need to be made on this line as well?
[develop]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything I'd say to revert it to a one-liner for push_request - I left it as an extra line/list to make it easier for myself to run CI on push to future branches, don't usually do PRs to other branches so I left that as the better one-liner.