Thanks to visit codestin.com
Credit goes to github.com

Skip to content

682 redundant checks #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristinamullin merged 15 commits into from
Oct 17, 2025
Merged

682 redundant checks #689

cristinamullin merged 15 commits into from
Oct 17, 2025

Conversation

@jbousquin
Copy link
Collaborator

@jbousquin jbousquin commented Oct 16, 2025

Draft PR for initial 3 items on checklist.

@jbousquin
Run checks/tests on push to this branch while working on it
393410e
@jbousquin
Use TADA_CheckType() for .data in TADA_CheckColumns()
f930ba0
@jbousquin
TADA_CheckColumns() checks type
9913dac
@jbousquin
TADA_CheckColumns() is checking type
87fb8f2
@jbousquin
Bring up to date w/ develop
a7eada4
@jbousquin
Update expected error for TADA_CheckColumns when input is not dataframe
bec9c6f
@jbousquin
missed one file update
b6784e8
@jbousquin
Resolve merge conflcits
4afb70a 
Merge remote-tracking branch 'origin/develop' into 682-redundant-checks

# Conflicts:
#	.github/workflows/R-CMD-check.yaml
#	.github/workflows/test-coverage.yaml
#	R/Transformations.R
#	R/Utilities.R
@jbousquin
Styler (files w/ minor changes)
8a4d1f1
@jbousquin
styler - whitespace
7d39ca5
@jbousquin
Styler changes to vignettes rmd files
c606f63
@jbousquin
Lost expected_ref_cols def in merge
3faa190
@jbousquin
All calls to TADA_CheckColumns() should follow a similar structure (i…
bd6aeac 
….e., define vector dircectly, or expected_cols if long).
@jbousquin
Prep for PR
c4828f3
@jbousquin jbousquin linked an issue Oct 16, 2025 that may be closed by this pull request
Redundant checks #682
Closed
3 tasks
@jbousquin
Copy link
Collaborator Author

jbousquin commented Oct 16, 2025

A lot to just reduce ~78 lines of code, but there was a stlyer update in there that probably added a few lines not accounted for there. See #682 for a couple options/changes not included.

@jbousquin jbousquin marked this pull request as draft October 16, 2025 21:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025 •
edited
Loading

coverage-report

File Coverage Missing
All files 33% ✅
R/ATTAINSCrosswalks.R 22% ✅ 64-742 931-941 945-949 954-957 962 970-973 980-983 988-1009 1017-1027 1052-1055 1179-1254 1266 1273-1451 1621-1633 1637-1640 1645-1647 1675-1678 1689-1692 1700-1704 1716-1720 1732-1738 1743-1754 1760 1768-1771 1861-1867 1872-1874 1979 1986-2157 2338-2724 2850-2853 2868 2876-2879 2886-2904 2912-2916 2927-2931 2947-3009 3013-3019 3056-3146 3151-3154 3159-3253
R/ATTAINSRefTables.R 0% ❌ 17-226
R/autoClean.R 85% ✅ 145-146 230-236 364-365 375-379
R/autoFilter.R 0% ❌ 27-430
R/CensoredDataSuite.R 88% ✅ 52-53 143 173-174 216-218 304-305 408-409 414 417 425 453-457 460-461 467-469 486-488
R/ContinuousDataFunctions.R 53% ✅ 151-152 184 189-259 266-267 290-328 345-349 352 392-393 483-547 552-596 603-610 615-616 655 666 672 677-684 709
R/CriteriaComparison.R 89% ✅ 159-161 166 176 223-241
R/CriteriaMethods.R 23% ✅ 155 175 185 191-250 404-406 422-424 529-669 675-711 733-984 1004-1172
R/CriteriaRefTables.R 0% ❌ 26-83
R/DataDiscoveryRetrieval.R 33% ✅ 197 206-211 225-230 240-245 251 255 270-676 690 698 700 704-707 710 716 718 722 724 730 734 736 746 748 752 758 760 764 766 771 773 777 783-786 789 801-809 822-828 857-865 879-887 907 1001-1033 1138-1145 1236-1272 1360-1363 1415-1574
R/DepthProfile.R 0% ❌ 96-1471
R/Figures.R 0% ❌ 64-1520
R/GeospatialFunctions.R 18% ✅ 70 163-165 176-180 184 239 277 321-548 689-690 696-699 708-922 927-1111 1279-1290 1307-1309 1311 1339 1345-1389 1416-1418 1496-1579 1589-2123 2203 2246 2267-3738
R/MaintenanceScheduled.R 0% ❌ 42-366
R/RequiredCols.R 16% ✅ 359-581
R/ResultFlagsDependent.R 62% ✅ 57 62 92-96 116-120 216 242-244 261-263 270 286-297 393 400 407 415 472 478 494-503 569 581-588 610 621-625 693-780 865 876 925-933 946 954 958 964-968
R/ResultFlagsIndependent.R 47% ✅ 69 75 108-134 238 246 253 260 265 276 348-349 366-403 491 496 503 574-583 594-609 697 702 708 785-963 1009 1028-1047 1058-1061 1163 1167 1210-1221 1226 1230-1233 1299-1537
R/Tables.R 77% ✅ 19-30 86
R/TADAGeospatialRefLayers.R 0% ❌ 8-13
R/TADARefTables.R 83% ✅ 72 82-86
R/Transformations.R 88% ✅ 76-77 82 179-185 343-344 380-381 465 540-541 709-722 808-809 820-821 826 841-844 847-856 860
R/UnitConversions.R 81% ✅ 128 344 351 358 365 372 379 386 393-394 520-584 608-645 668 708 722-731 923-925 1002 1059-1062 1092
R/Utilities.R 48% ✅ 28-32 183 299-300 304 309 382 391-406 484-492 553-554 561 623-624 654-658 758-759 769-773 778-779 822-1115 1141-1142 1153-1154 1214-1563 1656-1689
R/WQPWQXRefTables.R 63% ✅ 21-78 102 112 118-120 132 154 164 170-172 247 269 279 285-287 371 392 402 408-412 556 578 588 594-596 613 637 647 653-655 760-963

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 9f3283b

@jbousquin jbousquin marked this pull request as ready for review October 17, 2025 15:10
cristinamullin
cristinamullin reviewed Oct 17, 2025
View reviewed changes
cristinamullin
cristinamullin reviewed Oct 17, 2025
View reviewed changes
@jbousquin jbousquin mentioned this pull request Oct 17, 2025
Open
@cristinamullin
Copy link
Collaborator

cristinamullin commented Oct 17, 2025

Excellent updates! Thanks Justin

@cristinamullin cristinamullin merged commit 5c232ba into develop Oct 17, 2025
12 of 13 checks passed
@cristinamullin cristinamullin deleted the 682-redundant-checks branch October 17, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristinamullin cristinamullin cristinamullin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redundant checks

3 participants

@jbousquin @cristinamullin