Range flag update #699
Range flag update #699
Conversation
remove WQXCharValRef.csv and replace with WQXCharValRef.rda
consider ranges suspect if units are suspect, update continuous data function notes, update example data used for flag functions, update example data and refs
jbousquin
left a comment
There was a problem hiding this comment.
Looks like an old (>1 year) branch that was brought forward with some lingering changes (e.g., Data_Nutrients_UT -> Data_R5_TADAPackageDemo) that I don't have the context to ensure are intentional vs a revert that made it through merges.
I do see where the bad units handling was added to the two functions in ResulFlagsIndependent and it seems like it should accomplish what it is intended to.
The couple of in-line comments I made were whitespace formatting, a quick styler() run should fix throughout (approving without requiring changes to expedite).
|
Note that this makes these two functions longer while doing the same thing across both (relevant to #690) |
address 500 error
I ran styler to remove extra white space/blank lines. The switch from Data_Nutrients_UT -> Data_R5_TADAPackageDemo is intentional in the documentation for the flag functions. Data_Nutrients_UT is already somewhat clean (some functions have already been run on it) so it is not a good example for those. |
The upper and lower flag functions were not accounting for invalid units. If the units are not valid, then the ranges are not either and now those rows are also flagged as suspect.
TADA_FlagAboveThreshold
TADA_FlagBelowThreshold