I worked through through a lot of the check() errors and warnings.

I added a draft page following this: https://pkgdown.r-lib.org/articles/pkgdown.html. But I kept getting an error when trying to run this - "If you’re using GitHub, we also recommend setting up GitHub actions to automatically build and publish your site": usethis::use_pkgdown_github_pages(). I will revisit this in the future as well to try to set up automated Github page updates when the package is updated.

Any other feedback on the package setup/structure is welcome!

── R CMD check results ─────────────────────────────────────────────────── TADA 0.0.1 ────
Duration: 5m 36.5s

❯ checking tests ...
See below...

❯ checking installed package size ... NOTE
installed size is 5.1Mb
sub-directories of 1Mb or more:
extdata 4.9Mb

❯ checking top-level files ... NOTE
Non-standard files/directories found at top level:
'CONTRIBUTING.html' 'CONTRIBUTING.md' 'LICENSE.md' 'README.html'
'test_data'

❯ checking R code for possible problems ... NOTE
AboveNationalWQXUpperThreshold: no visible binding for global variable
'AboveWQXUpperThreshold'
AboveNationalWQXUpperThreshold: no visible binding for global variable
'Type'
AboveNationalWQXUpperThreshold: no visible binding for global variable
'Source'
AboveNationalWQXUpperThreshold: no visible binding for global variable
'Status'
AggregatedContinuousData: no visible binding for global variable
'ResultDetectionConditionText'
AggregatedContinuousData: no visible binding for global variable
'TADA.AggregatedContinuousData'
AutoFilter: no visible binding for global variable 'data'
AutoFilter: no visible binding for global variable 'ActivityMediaName'
BelowNationalWQXUpperThreshold: no visible binding for global variable
'BelowWQXUpperThreshold'
BelowNationalWQXUpperThreshold: no visible binding for global variable
'Type'
BelowNationalWQXUpperThreshold: no visible binding for global variable
'Source'
BelowNationalWQXUpperThreshold: no visible binding for global variable
'Status'
DepthProfileData: no visible binding for global variable 'Description'
DepthProfileData: no visible binding for global variable 'Target.Unit'
DepthProfileData: no visible binding for global variable
'Conversion.Factor'
FilterFieldReview: no visible binding for global variable 'Count'
FilterFieldReview: no visible binding for global variable 'FieldValue'
FilterFields: no visible binding for global variable 'FieldName'
FilterFields: no visible global function definition for 'where'
FilterFields: no visible binding for global variable 'setNames'
FilterParFieldReview: no visible binding for global variable 'Count'
FilterParFieldReview: no visible binding for global variable
'FieldValue'
FilterParFields: no visible binding for global variable
'CharacteristicName'
FilterParFields: no visible binding for global variable 'FieldName'
FilterParFields: no visible global function definition for 'where'
HarmonizationRefTable: no visible global function definition for
'read.csv'
HarmonizeData: no visible global function definition for 'read.csv'
InvalidCoordinates: no visible binding for global variable
'TADA.InvalidCoordinates'
InvalidFraction: no visible binding for global variable
'WQX.SampleFractionValidity'
InvalidFraction: no visible binding for global variable 'Type'
InvalidFraction: no visible binding for global variable 'Status'
InvalidMethod: no visible binding for global variable
'WQX.AnalyticalMethodValidity'
InvalidMethod: no visible binding for global variable 'Type'
InvalidMethod: no visible binding for global variable 'Status'
InvalidResultUnit: no visible binding for global variable
'WQX.ResultUnitValidity'
InvalidResultUnit: no visible binding for global variable 'Type'
InvalidResultUnit: no visible binding for global variable 'Status'
InvalidSpeciation: no visible binding for global variable
'WQX.MethodSpeciationValidity'
InvalidSpeciation: no visible binding for global variable 'Type'
InvalidSpeciation: no visible binding for global variable 'Status'
PotentialDuplicateRowID: no visible binding for global variable
'TADA.PotentialDupRowID'
QAPPDocAvailable: no visible binding for global variable
'ProjectFileUrl'
QAPPDocAvailable: no visible binding for global variable
'TADA.QAPPDocAvailable'
QAPPapproved: no visible binding for global variable
'QAPPApprovedIndicator'
RemoveEmptyColumns: no visible global function definition for 'select'
RemoveEmptyColumns: no visible global function definition for 'where'
TADAdataRetrieval: no visible global function definition for
'ends_with'
TADAdataRetrieval: no visible binding for global variable
'ActivityIdentifier'
TADAdataRetrieval: no visible binding for global variable
'MonitoringLocationIdentifier'
TADAdataRetrieval: no visible binding for global variable
'CharacteristicName'
TADAdataRetrieval: no visible binding for global variable
'ResultMeasureValue'
TADAdataRetrieval: no visible binding for global variable
'MethodSpecificationName'
WQXTargetUnits: no visible binding for global variable 'Type'
WQXTargetUnits: no visible binding for global variable 'Source'
WQXTargetUnits: no visible binding for global variable 'Status'
WQXTargetUnits: no visible binding for global variable 'Value.Unit'
WQXTargetUnits: no visible binding for global variable
'Conversion.Factor'
autoclean: no visible binding for global variable 'ActivityMediaName'
Undefined global functions or variables:
AboveWQXUpperThreshold ActivityIdentifier ActivityMediaName
BelowWQXUpperThreshold CharacteristicName Conversion.Factor Count
Description FieldName FieldValue MethodSpecificationName
MonitoringLocationIdentifier ProjectFileUrl QAPPApprovedIndicator
ResultDetectionConditionText ResultMeasureValue Source Status
TADA.AggregatedContinuousData TADA.InvalidCoordinates
TADA.PotentialDupRowID TADA.QAPPDocAvailable Target.Unit Type
Value.Unit WQX.AnalyticalMethodValidity WQX.MethodSpeciationValidity
WQX.ResultUnitValidity WQX.SampleFractionValidity data ends_with
read.csv select setNames where
Consider adding
importFrom("stats", "setNames")
importFrom("utils", "data", "read.csv")
to your NAMESPACE file.

❯ checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
'rlang' 'stringi'

── Test failures ────────────────────────────────────────────────────────────────── testthat ────

library(testthat)
library(TADA)

test_check("TADA")
Error in test_dir():
! No test files found
Backtrace:
▆

1. └─testthat::test_check("TADA")
2. └─testthat::test_dir("testthat", package = package, reporter = reporter, ..., load_package = "installed")

3. └─rlang::abort("No test files found")
   

Execution halted

1 error ✖ | 0 warnings ✔ | 4 notes ✖