Lazy load newest ref tables (fixes #72) #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamullin
approved these changes
Oct 4, 2022
Collaborator
|
Hi Florian, thank you for taking on this issue and for the elegant solution! Great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
just a quick PR for hacktoberfest.
#72 mentions the use of
.onLoadand.onAttachto update the data system files:This is very unusual behavior for an R package. Although I don't know of any official documentation mentioning this, but a package should probably not modify it's own files after installation. This PR realizes a different approach to solve this:
The (internal) functions
GetWQXCharValRef()andGetMeasureUnitRef()are introduced to lazily fetch and return the newest tables on demand. This means that they will cache the tables after downloading once (per session) to improve performance. No data is downloaded when none of them are called. If the download is unavailable (e.g. no internet connection) the internal tables are returned (and the user is notified).Functions
UpdateWQXCharValRef()andUpdateMeasureUnitRef()are still available to update the static project files (I assume this is what you used them for).Cheers,
Florian